[PATCH] include/obstack.h: do not hide _obstack_newchunk

[Bernhard Reutner-Fischer]

On 24 June 2013 15:25:20 "Anthony G. Basile" <basile at opensource.dyc.edu> wrote:
> On 06/23/2013 05:25 PM, Anthony G. Basile wrote:
> > On 06/23/2013 02:16 PM, Bernhard Reutner-Fischer wrote:
> >> On 23 June 2013 18:14:08 "Anthony G. Basile" <basile at opensource.dyc.edu>
> >> wrote:
> >>> From: "Anthony G. Basile" <blueness at gentoo.org>
> >>>
> >>> Programs using obstacks, like the suite of utilities provided by
> >>> coreutils, need _obstack_newchunk so we unhide the symbol.
> >>
> >> Eh, that sounds pretty broken. Are you sure this is the right thing to
> >> do? They should most likely obstack_*grow() instead.
> >>
> >> Please fix coreutils instead, or better yet, use Busybox.
> >> Thanks,
> >
>
> >
> > Let me do some poking around and see what's going on.
> >
> >
>
> Hi Bernhard,
>
> Actually its pretty clear what's going on here.  Many obstack functions are 
> implemented as macros around _obstack_newchunk, so "functions" like 
> obstack_*grow() are decls which expand to calls to _obstack_newchunk. Read 
> <obstack.h> around line 292.  Here's a simple poc:

Right, completely forgot this.
Thanks for the fix!


Sent with AquaMail for Android
http://www.aqua-mail.com