[PATCH v3 00/48] Support for cut-down Linux syscalls

[Bernhard Reutner-Fischer]

On 7 February 2013 14:19, Markos Chandras <markos.chandras at gmail.com> wrote:
> On 6 February 2013 18:11, Bernhard Reutner-Fischer
> <rep.dot.nop at gmail.com> wrote:
>>
>> Perhaps Will's suggestion of "generic-syscalls" is fine since the
>> kernel calls them generic, too.
>> common-generic overdoes it a bit, i guess, but it does produce a nice
>> tab-completion conflict with common.
>> So please rename it to common-generic and also add a hunk to
>> libc/sysdeps/linux/README to briefly explain what common-generic is.
>
> Fixed
>
>>
>> Reading through the series..
>>
>> I'd prefer if you could not put braces around the parameter of defined, e.g.:
>> +#if defined(__NR_fstat64) && !defined(__NR_fstat)
>> +#if defined __NR_fstat64 && !defined __NR_fstat
>> everywhere in those patches.
>
> Fixed
int fstat64(int fd, struct stat64 *buf)
 {
 	int result;
+#ifdef __ARCH_HAS_DEPRECATED_SYSCALLS__
+#else
+	return __syscall_fstat64(fd, buf);
+#endif
 }
 libc_hidden_def(fstat64)

obviously the guard should include the result declaration.

> Please let me know if you need me to fix anything else or if this
> branch is good enough for inclusion.

I think the result thing above should have shown up as new warning in
your series.
Perhaps you can look for other occurances (on e.g. i386/x86_64 or the
other arches that do support the at() interfaces in the kernel) in the
meantime.

But anyway, i'll have another look during the weekend.
Thanks for your patience!
cheers,