[PATCH] ldso/libdl: include dl-tls.h for mips static lin

Sat Feb 9 10:19:05 UTC 2013

On Mon, Feb 04, 2013 at 06:05:28PM -0800, Vincent Wen wrote:
>Mike,
>
>I removed the mips architect specific statement and tested on mips.
>Do you need help to test on other plamform like blackfin or ARM? Thanks.
>
>
>
>--- a/ldso/libdl/libdl.c    2013-01-25 05:57:55.000000000 -0800
>+++ b/ldso/libdl/libdl.c    2013-01-25 05:59:19.000000000 -0800
>@@ -44,6 +44,10 @@
> extern void _dl_add_to_slotinfo(struct link_map  *l);
> #endif
>
>+#if defined(USE_TLS) && !defined(SHARED)
>+#include <dl-tls.h>
>+#endif
>+
> #ifdef SHARED
> # if defined(USE_TLS) && USE_TLS
> # include <dl-tls.h>

Your hunk looks redundant to the SHARED right here.
Why does mips !SHARED elfinterp (unconditionally?) use TLS_DTPREL_VALUE?
Can you look if that is ok or if that's the real bug?

thanks,