[PATCH V2 8/8] MIPS: Fix more *_NONBLOCK definitions

Kevin Cernekee cernekee at gmail.com
Sun Apr 8 05:55:52 UTC 2012


On Sat, Apr 7, 2012 at 10:32 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Saturday 07 April 2012 16:31:32 Kevin Cernekee wrote:
>> The proposed change is to add #ifdef clauses for __mips__, similar to
>> what was done for SFD_NONBLOCK in include/sys/signalfd.h .  This fixes
>> the two failing test cases.
>
> we don't want arch ifdefs in these common files, nor do we want to diverge from
> glibc.  upstream glibc has finally gotten sane and converted to bits/inotify.h
> for handling arch-specific stuff.  let's import those updates instead.

Thanks for the quick review.  The original non-ifdef submission is here:

http://lists.uclibc.org/pipermail/uclibc/2012-February/046409.html

Some discussion which led to V2:

http://lists.uclibc.org/pipermail/uclibc/2012-February/046418.html
http://lists.uclibc.org/pipermail/uclibc/2012-February/046419.html

Re: documentation - is it worth explicitly mentioning these oddball
headers/definitions in docs/PORTING or is the current verbiage
sufficient?


More information about the uClibc mailing list