[git commit] add argument check in mknod

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Fri Jan 23 20:13:27 UTC 2015


commit: http://git.uclibc.org/uClibc/commit/?id=e55f589191162eb40f44696c77e569049313d381
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/master

mknod() in glibc/eglibc will check the argument, like this,
  ...
  if (k_dev != dev) {
      __set_errno (EINVAL);
      return -1;
   }
  ...
So add argument check in uclibc's mknod() too.

Signed-off-by: Wang Yufen <wangyufen at huawei.com>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 libc/sysdeps/linux/common/mknod.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/libc/sysdeps/linux/common/mknod.c b/libc/sysdeps/linux/common/mknod.c
index 416cab6..e0c54e6 100644
--- a/libc/sysdeps/linux/common/mknod.c
+++ b/libc/sysdeps/linux/common/mknod.c
@@ -24,6 +24,10 @@ int mknod(const char *path, mode_t mode, dev_t dev)
 	/* We must convert the value to dev_t type used by the kernel.  */
 	k_dev = (dev) & ((1ULL << 32) - 1);
 
+	if (k_dev != dev) {
+		__set_errno(EINVAL);
+		return -1;
+	}
 	return INLINE_SYSCALL(mknod, 3, path, mode, (unsigned int)k_dev);
 }
 #endif


More information about the uClibc-cvs mailing list