[git commit] test/math: fix for disabled long double math

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Mon Aug 18 10:11:52 UTC 2014


commit: http://git.uclibc.org/uClibc/commit/?id=50442f45302021af4f7d68fd91039469e1c14861
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/master

Commit "test: cater for config" http://git.uclibc.org/uClibc/commit/test/math/Makefile.in?id=7598eeaa1defa2884adaa890bb115c493d69cc35 inverted check from
	ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),y)
to
	ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),)
with first branch indeed inverted - instead of adding tests they were excluded.
But "else" branch was not moved up (remember check was inverted).

This causes compile breakage when building basic-test.c:
--->---
TEST_LINK math/ basic-test
basic-test.c: In function 'ldouble_test':
basic-test.c:111:1: warning: implicit declaration of function 'nanl' [-Wimplicit-function-declaration]
 TEST_FUNC (ldouble_test, long double, nanl, LDBL_EPSILON, HUGE_VALL)
 ^
basic-test.o: In function `main':
basic-test.c:(.text.startup+0x834): undefined reference to `nanl'
basic-test.c:(.text.startup+0x858): undefined reference to `nanl'
basic-test.c:(.text.startup+0x880): undefined reference to `nanl'
basic-test.c:(.text.startup+0x8a8): undefined reference to `nanl'
basic-test.c:(.text.startup+0x8d4): undefined reference to `nanl'
basic-test.o:basic-test.c:(.text.startup+0x8e0): more undefined references to `nanl' follow
collect2: error: ld returned 1 exit status
make[3]: *** [basic-test] Error 1
--->---

Fix is simple - merge "old else" branch with the first current one.

Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>

Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: Anton Kolesov <akolesov at synopsys.com>
Cc: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
Cc: Waldemar Brodkorb <wbx at openadk.org>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 test/math/Makefile.in |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/test/math/Makefile.in b/test/math/Makefile.in
index b495c0b..d4693b9 100644
--- a/test/math/Makefile.in
+++ b/test/math/Makefile.in
@@ -8,7 +8,6 @@ TESTS_DISABLED := libm-test
 TESTS_DISABLED += gamma
 ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),)
 TESTS_DISABLED += test-ldouble test-ildoubl compile_test c99_test
-else
 CFLAGS_basic-test := -DNO_LONG_DOUBLE
 endif
 ifeq ($(DO_C99_MATH),)


More information about the uClibc-cvs mailing list