[git commit] pmap_getport: use TCP to talk to portmapper if protocol == IPPROTO_TCP.

Denys Vlasenko vda.linux at googlemail.com
Mon Oct 7 14:46:11 UTC 2013


commit: http://git.uclibc.org/uClibc/commit/?id=c533aca08e29d4f659ca0ac011e5162b483dc6a9
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/master

Before the patch, the query itself was sent via UDP
(the query contained correct protocol ID).

The fix is taken from glibc.

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 libc/inet/rpc/pm_getport.c |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/libc/inet/rpc/pm_getport.c b/libc/inet/rpc/pm_getport.c
index ac20bb1..9a0e791 100644
--- a/libc/inet/rpc/pm_getport.c
+++ b/libc/inet/rpc/pm_getport.c
@@ -65,7 +65,19 @@ pmap_getport (struct sockaddr_in *address, u_long program, u_long version,
   struct pmap parms;
 
   address->sin_port = htons (PMAPPORT);
-  client = clntudp_bufcreate (address, PMAPPROG,
+  if (protocol == IPPROTO_TCP)
+    {
+      // glibc does this:
+      ///* Don't need a reserved port to get ports from the portmapper.  */
+      //socket = __get_socket(address); // does socket(TCP),bind(),connect(address)
+      //if (_socket != -1)
+      //  closeit = true;
+      // do we need/want to do the same?
+      client = clnttcp_create (address, PMAPPROG,
+	      PMAPVERS, &_socket, RPCSMALLMSGSIZE, RPCSMALLMSGSIZE);
+    }
+  else
+    client = clntudp_bufcreate (address, PMAPPROG,
 	      PMAPVERS, timeout, &_socket, RPCSMALLMSGSIZE, RPCSMALLMSGSIZE);
   if (client != (CLIENT *) NULL)
     {


More information about the uClibc-cvs mailing list