[git commit] resolv: fix memory leak

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Fri Oct 21 06:23:22 UTC 2011


commit: http://git.uclibc.org/uClibc/commit/?id=bb8d500a75a3050fe3198773ce7b07f669fe8f13
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/master

Timothy Holdener writes:
small memory leak in __dns_lookup() when the A record
in the DNS answer is preceded by one or more CNAME records.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 libc/inet/resolv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c
index 38254bd..e415d30 100644
--- a/libc/inet/resolv.c
+++ b/libc/inet/resolv.c
@@ -1507,6 +1507,7 @@ int attribute_hidden __dns_lookup(const char *name,
 		DPRINTF("Decoding answer at pos %d\n", pos);
 
 		first_answer = 1;
+		a->dotted = NULL;
 		for (j = 0; j < h.ancount; j++) {
 			i = __decode_answer(packet, pos, packet_len, &ma);
 			if (i < 0) {
@@ -1523,6 +1524,7 @@ int attribute_hidden __dns_lookup(const char *name,
 				ma.buf = a->buf;
 				ma.buflen = a->buflen;
 				ma.add_count = a->add_count;
+				free(a->dotted);
 				memcpy(a, &ma, sizeof(ma));
 				if (a->atype != T_SIG && (NULL == a->buf || (type != T_A && type != T_AAAA)))
 					break;


More information about the uClibc-cvs mailing list