[Bug 1507] [PATCH] ldd segfault fix

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1507

--- Comment #6 from Carmelo Amoroso <carmelo.amoroso at st.com>  ---
(In reply to comment #5)
> (In reply to comment #4)
> 
> >              }
> >          }
> > -        if (newlib == NULL)
> > +        if (newlib == NULL) {
> >              newlib = malloc(sizeof(struct library));
> > +            if (newlib)
> > +                newlib->next = NULL;
> > +        }
> > 
> > >>> why this one  ? why do you need to initialise the next field...
> > >>> if !newlib, we returns NULL anyway, so does it matter to set next ?
> > >>> is this change actually required to fix the segfault you have seen ?
> > >>> it seems not
> 
> Good question. I don't remember. I think you are right. probably not needed.

:) I would apply the minimal required fix, do you agree ?

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.