svn commit: branches/uClibc-nptl: include libc/stdlib/malloc-standard libc etc...

[Carmelo AMOROSO]

Khem Raj wrote:
> On (29/07/08 16:50), Carmelo AMOROSO wrote:
>> Carmelo AMOROSO wrote:
>>> kraj at uclibc.org wrote:
>>>> Author: kraj
>>>> Date: 2008-07-11 15:22:24 -0700 (Fri, 11 Jul 2008)
>>>> New Revision: 22805
>>>>
>>>> Log:
>>>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>>>> Hush compiler for extern inline warnings by using __extern_inline macro, this also makes gcc 4.3 happy.
>>>>
>>>> warning: C99 inline functions are not supported; using GNU89   
>>>> warning: to disable this warning use -fgnu89-inline or the gnu
>>>>
>>>> Also fix this other warning.
>>>>
>>>> warning: missing braces around initializer                     
>>>> warning: (near initialization for '_stdio_streams[0].__lock.__
>>>>
>>> libc/misc/utmp/utent.c:38: warning: braces around scalar initializer
>>> libc/misc/utmp/utent.c:38: warning: (near initialization for  
>>> 'utmplock.__data.__spins')
>>>
>>> any idea ? I'm not sure it's related to use of futex.
>>>
>>> Carmelo
>> Looked at this better, and I'm convinced it's not correct.
>> pthread_mutex_t contains all scalar entries, extra braces are not required.
> 
> well for arm and sh the union pthread_mutex_t are not same. ARM uses an
> aggregate inside this union 
> 
>     __extension__ union
>     {
>       int __spins;
>       __pthread_slist_t __list;
>     };
>  
> hence needs the braces around it and sh does
> not so it warns about the braces. 
> 
> look at the definitions in 
> 
> nptl/sysdeps/unix/sysv/linux/sh/bits/pthreadtypes.h
> and 
> nptl/sysdeps/unix/sysv/linux/arm/bits/pthreadtypes.h
> 
> -Khem
> 
Hi khem, I've seen. I think that arm nptl code is based on a newer 
release of glibc/nptl code than arm and mips. Indeed, looking at glibc 
2.6.1, pthread_mutex_t has been updated for sh as well.
I'll try to update sh hoping that I'll be not forced to update a lot of 
other part and test it again (I don't think it will break sh4-nptl at 
all). Anyway mips port will remain affected by the warning til Steve 
will updated it.

Thanks,
Carmelo