svn commit: branches/uClibc-nptl/libc

[Carmelo AMOROSO]

Carmelo AMOROSO wrote:
> kraj at uclibc.org wrote:
>> Author: kraj
>> Date: 2008-07-11 01:02:04 -0700 (Fri, 11 Jul 2008)
>> New Revision: 22772
>>
>> Log:
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> Append the objects.
>>
>>
>> Modified:
>>    branches/uClibc-nptl/libc/Makefile.in
>>
>>
>> Changeset:
>> Modified: branches/uClibc-nptl/libc/Makefile.in
>> ===================================================================
>> --- branches/uClibc-nptl/libc/Makefile.in	2008-07-11 07:59:33 UTC (rev 22771)
>> +++ branches/uClibc-nptl/libc/Makefile.in	2008-07-11 08:02:04 UTC (rev 22772)
>> @@ -38,17 +38,17 @@
>>  include $(libc_DIR)/unistd/Makefile.in
>>  
>>  ifeq ($(DOPIC),y)
>> -libc-a-y = $(libc-y:.o=.os) $(libc-static-y:.o=.os)
>> +libc-a-y += $(libc-y:.o=.os) $(libc-static-y:.o=.os)
>>  else
>> -libc-a-y = $(libc-y) $(libc-static-y)
>> +libc-a-y += $(libc-y) $(libc-static-y)
>>  endif
>>  
>>  ifeq ($(DOMULTI),n)
>> -libc-so-y = $(libc-y:.o=.os) $(libc-shared-y)
>> +libc-so-y += $(libc-y:.o=.os) $(libc-shared-y)
>>  else
>>  all_sources = $(libc-y:.o=.c)
>>  all_sources += $(libc-shared-y:.oS=.c)
>> -libc-multi-y = $(filter-out $(libc-nomulti-y:.o=.c),$(all_sources))
>> +libc-multi-y += $(filter-out $(libc-nomulti-y:.o=.c),$(all_sources))
>>  endif
>>  
>>  lib-a-y += $(top_builddir)lib/libc.a
>>
> 
> Khem
> if you need this fix, it menas that in some part you are using 
> erroneously libc-a-y and libc-so-y.
> Since a lot of time (aligned from trunk) we should use in internal 
> Makefile libc-y for file common in static and dynamic libs, 
> libc-shared-y for dynamic only and libc-static-y for dynamic only.
> So please review your arm Makefile and revert this change.
> 
> Ciao,
> Carmelo

Khem, I've checked all makefile on nptl branch and there is not a wrong 
use of these as I tought... so likely you have committed this simply 
based on an older version you had.
I'm going to revert this latest change.

Carmelo
>> _______________________________________________
>> uClibc-cvs mailing list
>> uClibc-cvs at uclibc.org
>> http://busybox.net/cgi-bin/mailman/listinfo/uclibc-cvs
>>
> 
> _______________________________________________
> uClibc-cvs mailing list
> uClibc-cvs at uclibc.org
> http://busybox.net/cgi-bin/mailman/listinfo/uclibc-cvs
>