svn commit: trunk/uClibc: include libc/inet libc/misc/syslog libc etc...

[vda at uclibc.org]

Author: vda
Date: 2008-04-27 18:15:34 -0700 (Sun, 27 Apr 2008)
New Revision: 21883

Log:
Experimentally move libc_hidden_proto(time) to time.h.
The only code change observed is actually a case
where we were not doing that as needed:

 00000000 <__GI_tzset>:
-53                     push   %ebx
-e8 00 00 00 00         call   6 <__GI_tzset+0x6>
-5b                     pop    %ebx
-81 c3 03 00 00 00      add    $0x3,%ebx
-                       R_386_GOTPC     _GLOBAL_OFFSET_TABLE_
 6a 00                  push   $0x0
-e8 fc ff ff ff         call   10 <__GI_tzset+0x10>
-                       R_386_PLT32     time
+e8 fc ff ff ff         call   3 <__GI_tzset+0x3>
+                       R_386_PC32      __GI_time
 3d ff 4e 98 45         cmp    $0x45984eff,%eax
 0f 9e c0               setle  %al
 0f b6 c0               movzbl %al,%eax
 50                     push   %eax
-e8 fc ff ff ff         call   21 <__GI_tzset+0x21>
+e8 fc ff ff ff         call   14 <__GI_tzset+0x14>
                        R_386_PC32      _time_tzset
 58                     pop    %eax
 5a                     pop    %edx
-5b                     pop    %ebx
 c3                     ret

No mass migration of libc_hidden_proto(foo) planned.
Lets wait for potential fallout first.



Modified:
   trunk/uClibc/Rules.mak
   trunk/uClibc/include/time.h
   trunk/uClibc/libc/inet/ifaddrs.c
   trunk/uClibc/libc/misc/syslog/syslog.c
   trunk/uClibc/libc/sysdeps/linux/common/time.c


Changeset:
Modified: trunk/uClibc/Rules.mak
===================================================================
--- trunk/uClibc/Rules.mak	2008-04-28 00:25:22 UTC (rev 21882)
+++ trunk/uClibc/Rules.mak	2008-04-28 01:15:34 UTC (rev 21883)
@@ -427,6 +427,9 @@
 endif
 endif
 
+# Please let us see private headers' parts
+CFLAGS += -DUCLIBC_INTERNAL
+
 # We need this to be checked within libc-symbols.h
 ifneq ($(HAVE_SHARED),y)
 CFLAGS += -DSTATIC

Modified: trunk/uClibc/include/time.h
===================================================================
--- trunk/uClibc/include/time.h	2008-04-28 00:25:22 UTC (rev 21882)
+++ trunk/uClibc/include/time.h	2008-04-28 01:15:34 UTC (rev 21883)
@@ -430,6 +430,13 @@
 
 __END_DECLS
 
+
+#ifdef UCLIBC_INTERNAL
+/* Experiment. Grep for 'libc_hidden_proto(time)' if need to revert */
+libc_hidden_proto(time)
+#endif
+
+
 #endif /* <time.h> included.  */
 
 #endif /* <time.h> not already included.  */

Modified: trunk/uClibc/libc/inet/ifaddrs.c
===================================================================
--- trunk/uClibc/libc/inet/ifaddrs.c	2008-04-28 00:25:22 UTC (rev 21882)
+++ trunk/uClibc/libc/inet/ifaddrs.c	2008-04-28 01:15:34 UTC (rev 21883)
@@ -41,7 +41,7 @@
 
 libc_hidden_proto(socket)
 libc_hidden_proto(close)
-libc_hidden_proto(time)
+/* Experimentally off - libc_hidden_proto(time) */
 libc_hidden_proto(sendto)
 libc_hidden_proto(recvmsg)
 libc_hidden_proto(bind)

Modified: trunk/uClibc/libc/misc/syslog/syslog.c
===================================================================
--- trunk/uClibc/libc/misc/syslog/syslog.c	2008-04-28 00:25:22 UTC (rev 21882)
+++ trunk/uClibc/libc/misc/syslog/syslog.c	2008-04-28 01:15:34 UTC (rev 21883)
@@ -102,7 +102,7 @@
 libc_hidden_proto(connect)
 libc_hidden_proto(sprintf)
 libc_hidden_proto(vsnprintf)
-libc_hidden_proto(time)
+/* Experimentally off - libc_hidden_proto(time) */
 
 #include <bits/uClibc_mutex.h>
 __UCLIBC_MUTEX_STATIC(mylock, PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP);

Modified: trunk/uClibc/libc/sysdeps/linux/common/time.c
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/common/time.c	2008-04-28 00:25:22 UTC (rev 21882)
+++ trunk/uClibc/libc/sysdeps/linux/common/time.c	2008-04-28 01:15:34 UTC (rev 21883)
@@ -11,7 +11,7 @@
 #include <time.h>
 #include <sys/time.h>
 
-libc_hidden_proto(time)
+/* Experimentally off - libc_hidden_proto(time) */
 
 #ifdef __NR_time
 _syscall1(time_t, time, time_t *, t);