[PATCH 2/2] sed: terminate branch commands at }

Csókás Bence csokas.bence at prolan.hu
Thu Mar 6 13:02:22 UTC 2025


Hi,

On 2025. 03. 05. 17:38, Jeremy Drake wrote:
> On Wed, 5 Mar 2025, Csókás Bence wrote:
> 
>> I would much rather have a separate `static const char []` for this instead.
> 
> At that point, both would only be used once.  In that case, would just
> putting the string inline be better, or is the `static const char []`
> still preferred?

It might be used more in the future. But yes, the optimal solution would 
be one that requires only one string constant. I don't currently have 
the brain capacity to figure that one out though.

Plus, it provides type safety, the ability to specify attributes, 
linking directives in a linker script etc. So for me, I'd prefer the 
static const variable.

Bence



More information about the busybox mailing list