[PATCH v5 9/9] httpd: disable execv call when applets are forced

Ron Yorston rmy at pobox.com
Thu Jan 30 09:07:10 UTC 2025


Nadav Tasher <tashernadav at gmail.com> wrote:
>Since httpd needs to execute a binary, we would not like
>it to succeed when busybox is configured not to execute
>external binaries.

Since FEATURE_FORCE_APPLETS will always result in CGI scripts failing
there's no point in enabling FEATURE_HTTPD_CGI.

How about this instead:

diff --git a/networking/httpd.c b/networking/httpd.c
index 872bab6b5..a479378c2 100644
--- a/networking/httpd.c
+++ b/networking/httpd.c
@@ -154,7 +154,7 @@
 //config:config FEATURE_HTTPD_CGI
 //config:  bool "Support Common Gateway Interface (CGI)"
 //config:  default y
-//config:  depends on HTTPD
+//config:  depends on HTTPD && !ENABLE_FEATURE_FORCE_APPLETS
 //config:  help
 //config:  This option allows scripts and executables to be invoked
 //config:  when specific URLs are requested.

Cheers,

Ron


More information about the busybox mailing list