[PATCH v2 3/3] syslogd: Add a configurable option to log timestamps in ISO 8601 format

[Grant Erickson]

On Apr 4, 2025, at 1:37 AM, Csókás Bence <csokas.bence at prolan.hu> wrote:
> On 2025. 04. 02. 16:43, Grant Erickson wrote:
>> @@ -353,38 +370,41 @@ enum {
>>   OPT_loglevel    = 1 << OPTBIT_loglevel,
>>   OPT_small       = 1 << OPTBIT_small   ,
>>   OPT_timestamp   = 1 << OPTBIT_timestamp,
>> - OPT_filesize    = IF_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_filesize   )) + 0,
>> - OPT_rotatecnt   = IF_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_rotatecnt  )) + 0,
>> - OPT_remotelog   = IF_FEATURE_REMOTE_LOG(    (1 << OPTBIT_remotelog  )) + 0,
>> - OPT_locallog    = IF_FEATURE_REMOTE_LOG(    (1 << OPTBIT_locallog   )) + 0,
>> - OPT_circularlog = IF_FEATURE_IPC_SYSLOG(    (1 << OPTBIT_circularlog)) + 0,
>> - OPT_dup         = IF_FEATURE_SYSLOGD_DUP(   (1 << OPTBIT_dup        )) + 0,
>> - OPT_cfg         = IF_FEATURE_SYSLOGD_CFG(   (1 << OPTBIT_cfg        )) + 0,
>> - OPT_kmsg        = IF_FEATURE_KMSG_SYSLOG(   (1 << OPTBIT_kmsg       )) + 0,
>> -    OPT_utc         = IF_FEATURE_SYSLOGD_UTC(   (1 << OPTBIT_utc        )) + 0,
>> + OPT_filesize    = IF_FEATURE_ROTATE_LOGFILE(    (1 << OPTBIT_filesize   )) + 0,
>> + OPT_rotatecnt   = IF_FEATURE_ROTATE_LOGFILE(    (1 << OPTBIT_rotatecnt  )) + 0,
>> + OPT_remotelog   = IF_FEATURE_REMOTE_LOG(        (1 << OPTBIT_remotelog  )) + 0,
>> + OPT_locallog    = IF_FEATURE_REMOTE_LOG(        (1 << OPTBIT_locallog   )) + 0,
>> + OPT_circularlog = IF_FEATURE_IPC_SYSLOG(        (1 << OPTBIT_circularlog)) + 0,
>> + OPT_dup         = IF_FEATURE_SYSLOGD_DUP(       (1 << OPTBIT_dup        )) + 0,
>> + OPT_cfg         = IF_FEATURE_SYSLOGD_CFG(       (1 << OPTBIT_cfg        )) + 0,
>> + OPT_kmsg        = IF_FEATURE_KMSG_SYSLOG(       (1 << OPTBIT_kmsg       )) + 0,
>> +    OPT_utc         = IF_FEATURE_SYSLOGD_UTC(       (1 << OPTBIT_utc        )) + 0,
>> +    OPT_iso8601fmt  = IF_FEATURE_SYSLOGD_ISO8601FMT((1 << OPTBIT_iso8601fmt )) + 0,
> 
> Now that you reformatted this whole block to be uniform-looking, why leave the last two lines' alignment inconsistent?

Bence:

Great catch, thanks. I’ve addressed the white space issues and have submitted v3.

Best,

Grant

-- 
Principal
Nuovations

gerickson at nuovations.com
https://www.nuovations.com/