[PATCH] syslogd: fork after init on a regular system, not before
Michael Tokarev
mjt at tls.msk.ru
Wed Jun 14 20:30:37 UTC 2023
13.06.2023 17:30, Denys Vlasenko wrote:
> I think we can delay daemonizing in both cases.
>
> Please try current git.
Yes, your version is better, it is definitely cleaner, especially
after the preparational patch.
But does it work for non-MMU case?
Or will it just open /dev/log twice and everything will be ok?
I'm not sure how important the non-MMU case is these days, to begin with.
The prob there is that you open stuff in parent and check for errors,
that's okay. But now you repeat the same open again in a new process
after exec, and you can only _hope_ things will work the same way one
more time, because you just did that a moment before. This is still
a bit dirty at least, I think. But "generally" will work.
Either way, this version definitely works ok on a regular system with MMU.
The same problem exists in klogd as well.
Thank you!
/mjt
More information about the busybox
mailing list