[PATCH] watchdog: make open-close-open functionality a config knob

[Rasmus Villemoes]

On 09/03/2021 13.33, Rasmus Villemoes wrote:
> On 01/03/2021 16.11, Rasmus Villemoes wrote:
>> When the nowayout option is used with a watchdog device, busybox'
>> current behaviour of always doing a open/write magic char/close
>> sequence before the "real" open causes warning messages in the kernel
>> log:
>>
>> [   16.212184] watchdog: watchdog0: nowayout prevents watchdog being stopped!
>> [   16.212196] watchdog: watchdog0: watchdog did not stop!
>>
>> The latter may also appear by itself in case the watchdog is of the
>> type that cannot be stopped once started.
>>
>> These warnings can be somewhat ominous and distracting, so allow
>> configuring whether to use this open-write-close-open sequence rather
>> than just open.
> 
> ping

ping^2

Come to think of it, I actually think the open_twice feature should be
default n. It seems one might as well start the watchdog daemon with a
wrapper that does "printf 'V' > /dev/watchdog0; exec watchdog ...". But
either way, please consider this patch.

Rasmus