[PATCH] vi: fix regex search compilation error

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Tue Jul 13 16:49:14 UTC 2021


On Tue, 13 Jul 2021 at 18:24, Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
>
> On Tue, 13 Jul 2021 16:35:43 +0100
> Ron Yorston <rmy at pobox.com> wrote:
>
> > Building with FEATURE_VI_REGEX_SEARCH enabled fails.
>

btw..
If i'm not mistaken, the s++ is fully redundant here although it seems
that my gcc-11 does not optimize it like if we manually spell it out
like in the attached?
Must be marked noinline to avoid inlining it twice it seems?!
If that double inlining really happens then the implied code growth
even for -Os is a different bug..

function                                             old     new   delta
colon                                               4527    4597     +70
strchr_backslash                                      38       -     -38
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/0 up/down: 70/-38)             Total: 32 bytes
thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vi-simplify-strchr_backslash.patch
Type: text/x-patch
Size: 365 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20210713/cda84f9c/attachment-0001.bin>


More information about the busybox mailing list