[PATCH] brctl: Added support for showmacs command

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Fri Sep 20 06:53:40 UTC 2019

On Mon, 16 Sep 2019 18:08:41 +0200
Martin Lewis <martin.lewis.x84 at gmail.com> wrote:

> Hi,
> The attached implementation is roughly the same found in brctl from
> bridge-utils.
> It does the same actions, and specifically reads it’s entries from
> /sys/class/net/<BRIDGE_NAME>/brforward.
> The relevant kernel function is brforward_read, and can be found under
> net/bridge/br_sysfs_br.c in the kernel source tree.
> All it does is provide the user an array of entries of the type struct
> __fdb_entry, which clearly contains a member __u8 mac_addr[ETH_ALEN],
> where ETH_ALEN is defined to be 6.

So please use ETH_ALEN and not 6.
> There are no references to Infiniband or in fact non-ethernet devices
> in the kernel’s bridge implementation,
> will you be able to please provide an example / code reference in
> which the above code breaks (as I couldn’t find any)?

You are right, this is not yet implemented.
I stand corrected and withdraw my comment.


More information about the busybox mailing list