[PATCH] dd: add 'oflag=append'

[Denys Vlasenko]

Applied, thanks!

On Wed, Feb 6, 2019 at 1:16 PM Rostislav Skudnov <rostislav at tuxera.com> wrote:
>
> Signed-off-by: Rostislav Skudnov <rostislav at tuxera.com>
> ---
>  coreutils/dd.c             | 16 ++++++++++------
>  docs/posix_conformance.txt |  1 +
>  2 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/coreutils/dd.c b/coreutils/dd.c
> index 4b31e9a..2fb9da7 100644
> --- a/coreutils/dd.c
> +++ b/coreutils/dd.c
> @@ -59,7 +59,7 @@
>  //usage:       "[if=FILE] [of=FILE] [" IF_FEATURE_DD_IBS_OBS("ibs=N obs=N/") "bs=N] [count=N] [skip=N] [seek=N]\n"
>  //usage:       IF_FEATURE_DD_IBS_OBS(
>  //usage:       "       [conv=notrunc|noerror|sync|fsync]\n"
> -//usage:       "       [iflag=skip_bytes|fullblock] [oflag=seek_bytes]"
> +//usage:       "       [iflag=skip_bytes|fullblock] [oflag=seek_bytes|append]"
>  //usage:       )
>  //usage:#define dd_full_usage "\n\n"
>  //usage:       "Copy a file with converting and formatting\n"
> @@ -84,6 +84,7 @@
>  //usage:     "\n       iflag=skip_bytes        skip=N is in bytes"
>  //usage:     "\n       iflag=fullblock Read full blocks"
>  //usage:     "\n       oflag=seek_bytes        seek=N is in bytes"
> +//usage:     "\n       oflag=append    Open output file in append mode"
>  //usage:       )
>  //usage:       IF_FEATURE_DD_STATUS(
>  //usage:     "\n       status=noxfer   Suppress rate output"
> @@ -140,11 +141,12 @@ enum {
>         /* start of output flags */
>         FLAG_OFLAG_SHIFT = 7,
>         FLAG_SEEK_BYTES = (1 << 7) * ENABLE_FEATURE_DD_IBS_OBS,
> +       FLAG_APPEND = (1 << 8) * ENABLE_FEATURE_DD_IBS_OBS,
>         /* end of output flags */
> -       FLAG_TWOBUFS = (1 << 8) * ENABLE_FEATURE_DD_IBS_OBS,
> -       FLAG_COUNT   = 1 << 9,
> -       FLAG_STATUS_NONE = 1 << 10,
> -       FLAG_STATUS_NOXFER = 1 << 11,
> +       FLAG_TWOBUFS = (1 << 9) * ENABLE_FEATURE_DD_IBS_OBS,
> +       FLAG_COUNT   = 1 << 10,
> +       FLAG_STATUS_NONE = 1 << 11,
> +       FLAG_STATUS_NOXFER = 1 << 12,
>  };
>
>  static void dd_output_status(int UNUSED_PARAM cur_signal)
> @@ -267,7 +269,7 @@ int dd_main(int argc UNUSED_PARAM, char **argv)
>         static const char iflag_words[] ALIGN1 =
>                 "skip_bytes\0""fullblock\0";
>         static const char oflag_words[] ALIGN1 =
> -               "seek_bytes\0";
> +               "seek_bytes\0append\0";
>  #endif
>  #if ENABLE_FEATURE_DD_STATUS
>         static const char status_words[] ALIGN1 =
> @@ -451,6 +453,8 @@ int dd_main(int argc UNUSED_PARAM, char **argv)
>
>                 if (!seek && !(G.flags & FLAG_NOTRUNC))
>                         oflag |= O_TRUNC;
> +               if (G.flags & FLAG_APPEND)
> +                       oflag |= O_APPEND;
>
>                 xmove_fd(xopen(outfile, oflag), ofd);
>
> diff --git a/docs/posix_conformance.txt b/docs/posix_conformance.txt
> index 0e6f4a3..f6e8858 100644
> --- a/docs/posix_conformance.txt
> +++ b/docs/posix_conformance.txt
> @@ -183,6 +183,7 @@ dd compatibility options:
>    iflag=skip_bytes|  yes   |           |
>    iflag=fullblock |  yes   |           |
>    oflag=seek_bytes|  yes   |           |
> +  oflag=append    |  yes   |           |
>
>  df POSIX options
>   option           | exists | compliant | remarks
> --
> 2.1.4
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox