[PATCH] make storage helpers common

[Xabier Oneca -- xOneca]

Hello Haroon,

2018-09-24 23:42 GMT+02:00 haroon maqsood <maqsood3525 at live.com>:
> On Mon, Sep 24, 2018 at 11:37:26PM +0200, Xabier Oneca -- xOneca wrote:
>> Wasn't introduced BUILD_BUG_ON(condition) for use in cases like
>> BUG_wrong_field_size() is used for? Although it seems in this case it
>> may not apply... :/
>>
> Unfortunately (for me) i am not sure why or when it was introduced, as i
> am new to busybox.
> do you think they should be separate ?

I am not the right person to give my view on this, because C is not my
main language.

I just remembered that BUILD_BUG_ON was introduced a while back (3
years: https://git.busybox.net/busybox/commit/?id=ab3964db4e75e34f6f9347406c5fd2bced04f2dd).
But it was also changed in runsv, which used same technique as here,
so I think it can be done. In separate patch? maybe. That's
subjective.

Cheers,

Xabier Oneca_,,_