[PATCH] addgroup , adduser series.

[Tito]

On 05/08/2018 10:51, haroon maqsood wrote:
> Hi
> 
> I started working on a patch for adduser utility i.e removing the fixme 
> and restructuring the code and implementing options S and D as they are 
> currently disabled.

Hi,
S Create a system user/group should be working in both adduser and
addgroup.
D as Disabled or empty password should be working in adduser and
is not needed in addgroup.
Can you explain a little more what you plan to do?

> i though it would make sense to send the first patch that is for 
> addgroup, as in my opinion adduser depends on addgroup

Why? Busybox's adduser can use an external addgroup binary
if need be.
> 
> and the configs are needed in both places , so they should be in addgroup.

Configs are generated by busybox's config system (e.g. make menuconfig)
and are shared by adduser and addgroup. Why do you need to move them
around?

[*]   Enable sanity check on user/group names in adduser and adgroup
(60000) Last valid uid or gid for adduser and addgroup
(100) First valid system uid or gid for adduser and addgroup 
           (999) Last valid system uid or gid for adduser and addgroup


Ciao,
Tito
> 
> let me know what you think.
> 
> Haroon
>