[PATCH 0/9] setpriv: dumping and modification of capabilities
Patrick Steinhardt
ps at pks.im
Fri Jun 30 06:00:09 UTC 2017
Hi Assaf,
On Thu, Jun 29, 2017 at 06:08:10PM -0400, Assaf Gordon wrote:
> Hello Patrick and all,
>
> > On Jun 29, 2017, at 13:34, Patrick Steinhardt <ps at pks.im> wrote:
> >
> > I've recently been digging into setpriv from util-linux and
> > implemented ambient capabilities.
> [...]
> > I first want to gauge interest in increasing the scope of setpriv
> > with these patches. If you as a project are interested, I'll
> > implement additional missing bits such as changing users and
> > groups, making it complete for at least my own use cases.
>
> This all looks good and useful to me (but i'm not a busybox developer).
Thanks for your feedback!
> One small suggestion: perhaps consider making each sub-part optional
> at compilation time? so that if someone doesn't need "--dump" or doesn't
> need "--cap" or "--inh-caps", they can build a smaller binary without them ?
This seems sensible and should be easy to achieve, I guess, as
the parts aren't too tangled up with each other. I'll await
additional feedback and do this in v2.
> Also,
> Thanks for spotting and fixing the getopt bug in my previous code.
>
> regards,
> - assaf
Regards
Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20170630/5d280c34/attachment.asc>
More information about the busybox
mailing list