[PATCH 3/3] ash: use JOBS as the compile time option it actually is

Denys Vlasenko vda.linux at googlemail.com
Fri Jul 14 18:08:31 UTC 2017


On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
<johannes.schindelin at gmx.de> wrote:
> Using the constant in a regular `if (...)` pretends that this is
> anything but a compile time option. Let's use `#if JOBS` instead,
> making it *much* clearer what `JOBS` actually is.
>
> Incidentally, this change fixes the build in setups where there are
> no headers defining WIFSTOPPED and WSTOPSIG (where JOBS has to be
> set to 0).
>
> This partially reverts 4700fb5be (ash: make dowait() a bit more
> readable. Logic is unchanged, 2015-10-09).

Some people (not me) have the completely opposite POV
and used to ask me to remove excessive #ifs.

It's difficult to find a middle ground here...


More information about the busybox mailing list