[PATCH 3/3] Clarify help text of CONFIG_{SH,BASH}_IS_* options.

[Denys Vlasenko]

Applied, thanks!

On Wed, Jan 4, 2017 at 1:57 AM, Kang-Che Sung <explorer09 at gmail.com> wrote:
> (This mail and patch was sent to busybox mailing list on Dec 25, 2016,
> and I'm re-sending again for people to notice.)
>
> Mention the behavior if user selects CONFIG_SH_IS_ASH but not
> CONFIG_ASH. We will be explicit that invocations like "busybox ash"
> will not work for such configuration.
>
> Also clarify help text of CONFIG_BASH_IS_* that bash compatibility in
> ash is not complete. (It shouldn't be anyway - ash can't support every
> bash quirk out there.)
>
> Signed-off-by: Kang-Che Sung <explorer09 at gmail.com>
> ---
>  shell/Config.src | 28 +++++++++++++++++++++++++++-
>  1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/shell/Config.src b/shell/Config.src
> index 1fb05fab6..997f42f91 100644
> --- a/shell/Config.src
> +++ b/shell/Config.src
> @@ -19,12 +19,24 @@ choice
>  config SH_IS_ASH
>   depends on !NOMMU
>   bool "ash"
> + help
> +  Choose ash to be the shell executed by 'sh' name.
> +  The ash code will be built into busybox. If you didn't say Y to the
> +  "ash" choice (CONFIG_ASH) above, this shell may only be invoked by
> +  the name 'sh' (and not 'ash').
>
>  config SH_IS_HUSH
>   bool "hush"
> + help
> +  Choose hush to be the shell executed by 'sh' name.
> +  The hush code will be built into busybox. If you didn't say Y to the
> +  "hush" choice (CONFIG_HUSH) above, this shell may only be invoked by
> +  the name 'sh' (and not 'hush').
>
>  config SH_IS_NONE
>   bool "none"
> + help
> +  Do not support 'sh' applet name in busybox.
>
>  endchoice
>
> @@ -33,7 +45,8 @@ choice
>   default BASH_IS_NONE
>   help
>    Choose which shell you want to be executed by 'bash' alias.
> -  The ash shell is the most bash compatible and full featured one.
> +  The ash shell is the most bash compatible and full featured one,
> +  although not complete.
>
>    Note that selecting this option does not switch on any bash
>    compatibility code. It merely makes it possible to install
> @@ -48,12 +61,25 @@ choice
>  config BASH_IS_ASH
>   depends on !NOMMU
>   bool "ash"
> + help
> +  Choose ash to be the shell executed by 'bash' name.
> +  The ash code will be built into busybox. If you didn't say Y to the
> +  "ash" choice (CONFIG_ASH) above, this shell may only be invoked by
> +  the name 'bash' (and not 'ash').
> +
>
>  config BASH_IS_HUSH
>   bool "hush"
> + help
> +  Choose hush to be the shell executed by 'bash' name.
> +  The hush code will be built into busybox. If you didn't say Y to the
> +  "hush" choice (CONFIG_HUSH) above, this shell may only be invoked by
> +  the name 'bash' (and not 'hush').
>
>  config BASH_IS_NONE
>   bool "none"
> + help
> +  Do not support 'bash' applet name in busybox.
>
>  endchoice
>
> --
> 2.11.0
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox