Potential regression with ash "pause()" commit

Denys Vlasenko vda.linux at googlemail.com
Thu Nov 3 19:22:11 UTC 2016


On Tue, Nov 1, 2016 at 6:51 AM, Kang-Che Sung <explorer09 at gmail.com> wrote:
> Hello.
>
> I want to mention that in this commit
> "ash: use pause(), not sigsuspend(), in wait builtin"
> 8f7b0248adca9a88351fd7f3dd208775242f3fe6
> there could be a regression.
>
> I recently read about Problems with pause() in glibc manual
> <https://www.gnu.org/software/libc/manual/html_node/Pause-Problems.html>
> and this is why they recommend against using pause(): The signal could
> arrive after the (!pending_sig) check but before the pause(), causing
> the pause() to miss the signal or hang there indefinitely.

Indeed! Thanks, fixed it in git.


More information about the busybox mailing list