[PATCH] scripts/trylink: use portable invocation of mktemp

Andrew Oates andrew at andrewoates.com
Tue Jul 12 12:41:30 UTC 2016


Thanks!

On Tue, Jul 12, 2016 at 7:55 AM, Denys Vlasenko <vda.linux at googlemail.com>
wrote:

> On Mon, Jul 11, 2016 at 3:44 PM, Brad Kemp <brad at beechwoods.com> wrote:
> >
> > On Jul 10, 2016, at 8:33 PM, Andrew Oates <andrew at andrewoates.com>
> wrote:
> >
> > --tmpdir unfortunately doesn't work on OS X/BSD-style mktemp, but '-t'
> does.
> > So "mktemp -t tmp.XXXXXXXXXX" obeys TMPDIR on both Linux and OS X.  "-t"
> is
> > marked as deprecated in the Linux version's manpage, however --- not
> sure if
> > you consider that a problem.
> >
> > Alternatively, it could just run "mktemp tmp.XXXXXXXXXX", which creates
> the
> > temporary file in the current directory on both systems.  Not ideal, but
> > consistent (and maybe that's fine given how the script is used in the
> build
> > system?)
> >
> > The local directory may not be writeable
>
> Then link will fail anyway: linker writes resulting binary there.
>
> I committed a change with "mktemp tmp.XXXXXXXXXX"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20160712/a0cab45d/attachment.html>


More information about the busybox mailing list