[PATCH] Remove a compilation warning

Denys Vlasenko vda.linux at googlemail.com
Fri Jan 1 23:53:47 UTC 2016


Applied, thanks

On Thu, Dec 31, 2015 at 11:01 AM, Cristian Ionescu-Idbohrn
<cristian.ionescu-idbohrn at axis.com> wrote:
> Reported by gcc (Debian 5.3.1-4) 5.3.1 20151219
>
> shell/ash.c: In function 'evaltree':
> shell/ash.c:8432:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>    if (!exitstatus == is_or)
>                    ^
>
> Signed-off-by: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>
> ---
>  shell/ash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/shell/ash.c b/shell/ash.c
> index e7a867f..daec975 100644
> --- a/shell/ash.c
> +++ b/shell/ash.c
> @@ -8429,7 +8429,7 @@ evaltree(union node *n, int flags)
>                         n->nbinary.ch1,
>                         (flags | ((is_or >> 1) - 1)) & EV_TESTED
>                 );
> -               if (!exitstatus == is_or)
> +               if ((!exitstatus) == is_or)
>                         break;
>                 if (!evalskip) {
>                         n = n->nbinary.ch2;
> --
> 2.6.4
>
>
> Cheers,
>
> --
> Cristian
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox


More information about the busybox mailing list