[PATCH] init: allow to preserve init's command-line

Mike Frysinger vapier at gentoo.org
Wed Feb 3 17:39:32 UTC 2016


On 03 Feb 2016 12:45, Daniel Thompson wrote:
> On 03/02/16 12:29, Nicolas CARRIER wrote:
> > Honestly, I hesitated to propose the inverse feature.
> > I think the key point is : what we consider "normal" behavior ?
> > I tend to consider it's "keep your arguments as they were passed to
> > you", but I felt there was more people favoring the "do as you've
> > always done".
> 
> Defaults are enough to handle "normal" behavior; inverting the 
> definition of a feature isn't helpful.
> 
> It is far better (and more intuitive) if: feature off -> smaller code

naming wise, FEATURE_INIT_MODIFY_CMDLINE is fine.  the "default" value
can be easily used to set the state regardless of naming and inverted.

i have no strong opinion either way as to the default.  disabling the
munging by default does yield smaller code.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20160203/3879c7e9/attachment.asc>


More information about the busybox mailing list