[PATCH] CONFIG_FTPD should select FEATURE_LS_TIMESTAMPS

[Xabier Oneca -- xOneca]

Hello Denys,

2015-02-15 14:58 GMT+01:00 Denys Vlasenko <vda.linux at googlemail.com>:
> On Sun, Feb 15, 2015 at 8:03 AM, Explorer <explorer09 at gmail.com> wrote:
>> From 60836c395e0d1a71da573175fde410cc69e67b78 Mon Sep 17 00:00:00 2001
>> From: Explorer09 <explorer09 at gmail.com>
>> Date: Sun, 15 Feb 2015 14:50:34 +0800
>> Subject: [PATCH] CONFIG_FTPD should select FEATURE_LS_TIMESTAMPS
>>
>> This adds a 'select' line that if ftpd and ls are both enabled, ls
>> timestamps
>> feature will always be selected.
>>
>> Without this line, FEATURE_LS_TIMESTAMPS will still be enabled internally
>> due
>> to the macro lines like this in ls.c:
>>   #if ENABLE_FTPD
>>   # undef CONFIG_FEATURE_LS_TIMESTAMPS
>>   ...
>>   # define CONFIG_FEATURE_LS_TIMESTAMPS 1
>>   ...
>>   #endif
>>
>> I would like to have kconfig handle the dependency and letting it explicit
>> to
>> builders.
>>
>> Signed-off-by: Kang-che Sung <explorer09-at-gmail.com>
>
> I don't think this change is useful.

You refer to the fact that the config was select'ed, but the code was
not cleaned, don't you?

Cheers,

Xabier Oneca_,,_