AW: [PATCH 5/5] Bionic lacks transparent LFS migrations; provide a workaround

[dietmar.schindler at manroland-web.com]

> Von: Rich Felker [mailto:dalias at aerifal.cx]
> Gesendet: Dienstag, 28. April 2015 01:02
>
> On Mon, Apr 27, 2015 at 06:30:59AM +0000, dietmar.schindler at manroland-web.com wrote:
> > > On Friday, 24 April 2015, at 4:12 am, Matt Whitlock wrote:
> > > > +#if defined(__BIONIC__) && _FILE_OFFSET_BITS == 64
> > >
> > > The preprocessor needs to test whether _FILE_OFFSET_BITS is defined before using it in an
> > > expression.
> >
> > That's not true. INTERNATIONAL STANDARD ©ISO/IEC ISO/IEC 9899:201x,
> > Programming languages - C, 6.10.1 Conditional inclusion, §4:
> > "... After all replacements due to macro expansion and the *defined*
> > unary operator have been performed, all remaining identifiers ...
> > are replaced with the pp-number 0..."
> >
> > Thus, it's not needed to write
> >
> > > #if defined(__BIONIC__) && defined(_FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64
>
> It's a matter of policy. While it's valid C, -Wundef generates
> warnings for such usage and thus policy is to avoid it.

Whose policy is that which caters to a certain compiler option's inept warnings? "What are the goals of Busybox?" (http://www.busybox.net/FAQ.html#goals) says: "We also want to have the simplest and cleanest implementation we can manage..." - I wouldn't say that

#if defined(__BIONIC__) && defined(_FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64

is as simple and clean as

#if defined(__BIONIC__) && _FILE_OFFSET_BITS == 64
--
Regards,
Dietmar
________________________________
manroland web systems GmbH -- Managing Director: Joern Gosse
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No.: 26816 -- VAT: DE281389840

Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.

! Please consider your environmental responsibility before printing this eMail !
________________________________