[PATCH] libbb: remove unnecessary argument to nonblock_immune_read

Denys Vlasenko vda.linux at googlemail.com
Mon Apr 20 11:51:47 UTC 2015


On Sun, Apr 19, 2015 at 6:07 PM, Rich Felker <dalias at libc.org> wrote:
> On Sun, Apr 19, 2015 at 10:50:25AM +0100, Ron Yorston wrote:
>> The loop_on_EINTR argument to nonblock_immune_read is always set to 1.
>>
>> function                                             old     new   delta
>> xmalloc_reads                                        200     195      -5
>> pgetc                                                488     483      -5
>> argstr                                              1313    1308      -5
>> nonblock_immune_read                                 123      86     -37
>> ------------------------------------------------------------------------------
>> (add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-52)             Total: -52 bytes
>
> An even better question is whether the looping code could be
> eliminated entirely. Are any of the bb commands that use this code
> installing interurpting signal handlers? If not then the code for
> supporting EINTR is useless.

ash uses this function.


More information about the busybox mailing list