[PATCH] libbb: remove unnecessary argument to nonblock_immune_read
Rich Felker
dalias at libc.org
Sun Apr 19 16:07:12 UTC 2015
On Sun, Apr 19, 2015 at 10:50:25AM +0100, Ron Yorston wrote:
> The loop_on_EINTR argument to nonblock_immune_read is always set to 1.
>
> function old new delta
> xmalloc_reads 200 195 -5
> pgetc 488 483 -5
> argstr 1313 1308 -5
> nonblock_immune_read 123 86 -37
> ------------------------------------------------------------------------------
> (add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-52) Total: -52 bytes
An even better question is whether the looping code could be
eliminated entirely. Are any of the bb commands that use this code
installing interurpting signal handlers? If not then the code for
supporting EINTR is useless.
Rich
More information about the busybox
mailing list