[PATCH] Ntpd config file support

Harald Becker ralda at gmx.de
Sat Mar 22 19:40:48 UTC 2014


Hi Isaac !

Your program will fail on lines starting with the word server
(eg. serverxyz), that is it does not check for clear word
boundary and gives wrong results in that case.

>while (cbuf[i] > 35) i++;

Unwise to do this in a not poor ASCII environment, as most
systems are nowadays. This way you allow unprintable and any
kind of illegal characters in time server addresses. ... and what
about buffer overflow? Won't this loop then run to unknown
locations?

Beside this: Make it a default NO configuration, not being
included in binaries build from standard options.

--
Harald


More information about the busybox mailing list