[PATCH] Use the standard libc types in fatattr

Laszlo Papp lpapp at kde.org
Fri Jul 4 13:26:56 UTC 2014


On Fri, Jul 4, 2014 at 2:17 PM, Denys Vlasenko <vda.linux at googlemail.com>
wrote:

> On Fri, Jul 4, 2014 at 3:55 PM, Isaac Dunham <ibid.ag at gmail.com> wrote:
> > (rather than gratuitously copying every kernel-speific int type.)
> > ---
> >  util-linux/fatattr.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/util-linux/fatattr.c b/util-linux/fatattr.c
> > index 0f8d632..5d93387 100644
> > --- a/util-linux/fatattr.c
> > +++ b/util-linux/fatattr.c
> > @@ -34,8 +34,8 @@
> >  #include "libbb.h"
> >  /* linux/msdos_fs.h says: */
> >  #ifndef FAT_IOCTL_GET_ATTRIBUTES
> > -# define FAT_IOCTL_GET_ATTRIBUTES        _IOR('r', 0x10, __u32)
> > -# define FAT_IOCTL_SET_ATTRIBUTES        _IOW('r', 0x11, __u32)
> > +# define FAT_IOCTL_GET_ATTRIBUTES        _IOR('r', 0x10, uint32_t)
> > +# define FAT_IOCTL_SET_ATTRIBUTES        _IOW('r', 0x11, uint32_t)
> >  #endif
> >
> >  /* Currently supports only the FAT flags, not the NTFS ones.
>
>
> Applied, thanks!
>
> (why kernel doesn't just use std types?...)
>

What do you mean by "std types"? Those are definitely not standard for the
kernel. The kernel is built with older C standards than C99 at times.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140704/29e209ee/attachment.html>


More information about the busybox mailing list