[PATCH] Config: select PLATFORM_LINUX if using sendfile()

Ralf Friedl Ralf.Friedl at online.de
Wed Dec 10 13:20:02 UTC 2014


Bartosz Golaszewski wrote:
> Man entry for sendfile:
>
>    Not specified in POSIX.1-2001, or other standards.
>
>    Other UNIX systems implement sendfile() with different  semantics  and
>    prototypes. It should not be used in portable programs.
>
> Select PLATFORM_LINUX if enabling FEATURE_USE_SENDFILE.
>
> Signed-off-by: Bartosz Golaszewski <bartekgola at gmail.com>
> ---
>   Config.in | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Config.in b/Config.in
> index 285fe0a..07b4bf3 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -267,6 +267,7 @@ config PAM
>   config FEATURE_USE_SENDFILE
>   	bool "Use sendfile system call"
>   	default y
> +	select PLATFORM_LINUX
>   	help
>   	  When enabled, busybox will use the kernel sendfile() function
>   	  instead of read/write loops to copy data between file descriptors
I suggest ddoing it the other way, enable sendfile only for Linux.
As it is, sendfile is enabled by default, which would automatically 
select Linux, which might select other things that don't work on 
non-Linux systems.





More information about the busybox mailing list