bootchartd: depends on tar -z functionality

[Xabier Oneca -- xOneca]

Hello,

2013/11/3 Thomas De Schampheleire <patrickdepinguin+busybox at gmail.com>:
> On Sun, Nov 3, 2013 at 12:08 AM, Denys Vlasenko
> <vda.linux at googlemail.com> wrote:
>> On Wednesday 23 October 2013 15:57, Thomas De Schampheleire wrote:
>>> Hi,
>>>
>>> The bootchartd applet writes its results with 'tar -z' which only
>>> works if the system has a full 'tar' and 'gzip', or has busybox tar
>>> but with gzip functionality enabled (FEATURE_SEAMLESS_GZ).
>>>
>>> Currently there is no check on this whatsoever, and bootchartd simply
>>> fails to write its data on the filesystem.
>>>
>>> What is the best approach here?
>>>
>>> 1. let bootchartd depend on FEATURE_SEAMLESS_GZ: trivial change, but
>>> hides bootchartd from config if this feature is not enabled; can be
>>> confusing. Also, if the user has a real non-busybox tar that supports
>>> '-z' this is not needed.
>>>
>>> 2. let bootchartd select FEATURE_SEAMLESS_GZ: trivial change, but
>>> makes busybox include features the user is not really aware of. Also
>>> not needed in case there is a full 'tar -z'.
>>>
>>> 3. change bootchartd to write uncompressed data
>>>
>>> 4. change bootchartd to check if compression is possible. If yes, do
>>> it, if not then write as plain tar.
>>>
>>> 5. other options?

Why not just leave the files as-is if there's no tar and/or gzip?

Just make a forlder named bootchart and put all files into it.

Let the user pack them to analyze them. (Likely on another computer.
What purpose is having bootchart png/svg generator and not tar/gzip in
the system?)

> Therefore I suggest to also mention something in the config option
> help, possibly also referring to the SEAMLESS_GZ option.

I vote for the that.

--
Xabier Oneca_,,_