[PATCH] udhcp: Add config file option (code 209) definition

[Denys Vlasenko]

On Mon, Nov 4, 2013 at 2:49 AM, Jeremy Kerr <jk at ozlabs.org> wrote:
> This change adds a definition for DHCP option 209. RFC 5071 defines code
> 209 as a configuration file for a PXE bootloader; this change uses
> the string "conffile" as its text identifier.
>
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
>
> ---
>  networking/udhcp/common.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/networking/udhcp/common.c b/networking/udhcp/common.c
> index 11b7b1f..6f7cd4f 100644
> --- a/networking/udhcp/common.c
> +++ b/networking/udhcp/common.c
> @@ -62,6 +62,7 @@ const struct dhcp_optflag dhcp_optflags[] = {
>         { OPTION_U16                              , 0x84 }, /* DHCP_VLAN_ID       */
>         { OPTION_U8                               , 0x85 }, /* DHCP_VLAN_PRIORITY */
>  #endif
> +       { OPTION_STRING | OPTION_REQ              , 0xd1 }, /* DHCP_CONF_FILE     */

OPTION_REQ means that udhcpc will request this option by default
(meaning: even without "-O conffile").

Why do you want this?

>         { OPTION_6RD                              , 0xd4 }, /* DHCP_6RD           */
>         { OPTION_STATIC_ROUTES | OPTION_LIST      , 0xf9 }, /* DHCP_MS_STATIC_ROUTES */
>         { OPTION_STRING                           , 0xfc }, /* DHCP_WPAD          */
> @@ -128,6 +129,7 @@ const char dhcp_option_strings[] ALIGN1 =
>         "vlanid" "\0"      /* DHCP_VLAN_ID        */
>         "vlanpriority" "\0"/* DHCP_VLAN_PRIORITY  */
>  #endif
> +       "conffile" "\0"    /* DHCP_CONF_FILE      */

"conffile" sounds a bit too generic...

In general, I would like to avoid adding more and more custom options.
"-O OPT" and "-x OPT:VAL" were added to make it possible
to, respectively, request and send any options, even ones
udhcpc does not know about: decimal and hex notations
are supported.

Did you try using them?

-- 
vda