AW: [PATCH] ubimkvol: add -m option to create volume of maximum size

[dietmar.schindler at manroland-web.com]

> Von: busybox-bounces at busybox.net Im Auftrag von Mike Frysinger
> Gesendet: Samstag, 1. Juni 2013 01:31
> An: busybox at busybox.net
>
> On Tuesday 28 May 2013 17:35:29 Paul B. Henson wrote:
> > +                   if (sscanf(ubi_ctrl, "/dev/ubi%u", &ubinum) != 1)
> > +                           bb_error_msg_and_die("%s device node not in correct format", "UBI");
>
> seems like all of these sscanf would be better off using the existing xstrtou() helpers ?
> ...

Since you don't seem to have followed the conversation, and Mr. Paul B. Henson asked to reply to the original message, I restate my concern: Are you sure that the version with xstrtou is shorter (which is the motivation for the change, if I understand right)? I doubt it. Besides that, the version with sscanf is far more readable, especially with multiple conversions embedded in the format.
--
Best regards,
Dietmar Schindler
________________________________________
manroland web systems GmbH -- Managing Director: Eckhard Hoerner-Marass
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No. 26816 -- VAT: DE281389840

Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.

! Please consider your environmental responsibility before printing this eMail
________________________________________