[PATCH] ubimkvol: add -m option to create volume of maximum size

Paul B. Henson henson at acm.org
Mon Jun 3 18:32:58 UTC 2013


On 6/2/2013 10:44 PM, Tito wrote:

>> +				bb_error_msg_and_die("%s device node not in correct format", "UBI");
>
> Why not                  bb_error_msg_and_die("UBI device node not in correct format");

I'm just matching all of the existing calls in the code:

bb_error_msg_and_die("%s device not specified", "UBI");
bb_error_msg_and_die("%s size not specified", "UBI");
bb_error_msg_and_die("%s name not specified", "UBI");
bb_error_msg_and_die("%s volume name too long", "UBI");
bb_error_msg_and_die("%s volume id not specified", "UBI");
bb_error_msg_and_die("%s size not specified", "UBI");
bb_error_msg_and_die("%s volume id not specified", "UBI");
bb_error_msg_and_die("%s volume node not in correct format", "UBI");
bb_error_msg_and_die("%s could not get LEB size", "UBI");
bb_error_msg_and_die("%s could not get LEB size", "UBI");

I've got no idea why the original implementer did it that way, but when 
in Rome…



More information about the busybox mailing list