[PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

Paul B. Henson henson at acm.org
Mon Jun 3 01:18:55 UTC 2013


On Sun, Jun 02, 2013 at 03:23:18AM -0400, Mike Frysinger wrote:

> i think libbb has grown to the point where it needs to start providing
> its own API reference :/.  it's been a while since i hacked seriously
> on busybox, so i've lost touch with much of its deeper layers.
[...]
> inputs.  it's probably safe to assume that they aren't all going to behave 
> exactly the same.  should we create duplicate implementations to satisfy them 
> all ?  or just take the slightly rough edges for the sake of smaller code ?  
> i'm in the latter camp.

Turns out the suite of xstrtou functions had a variant allowing an
arbitrary mapping of suffix to multiplier to be passed in which worked
perfectly. I submitted an updated patch using it which is simpler and
doesn't add any local utility function.

Hopefully this latest set of patches will pass muster :), if not let me
know what else you'd like to see changed.

Thanks...



More information about the busybox mailing list