[PATCH] udhcpc: gracefully handle packets with CHECKSUM_PARTIAL

Denys Vlasenko vda.linux at googlemail.com
Mon Sep 17 14:07:57 UTC 2012


On Mon, Sep 17, 2012 at 3:23 PM, Alexey I. Froloff <raorn at raorn.name> wrote:
> On Mon, Sep 17, 2012 at 02:33:18PM +0200, Denys Vlasenko wrote:
>> Can VM's disable checksumming not wholesale, but on
>> per-port basis? DHCP packets are such a tiny minority
>> of the typical traffic it's not worth saving nanoseconds on them.
> VM does not "disable" checksumming, as far as I understand from
> the Dave's explainations.  Checksumming is often offloaded to
> NICs, while KVM's vhost-net does not have this functionality by
> design.  Same thing happens with Xen.  In RedHat similar patch
> was applied to ISC DHCP for Xen hypervisors.  I believe this
> happens when client and server are running in different VMs on
> one Hypervisor ans connected via single bridge.
>
> On the other hand, this is only needed on x86 architectures when
> running in virtualized environment, where size does not matter.
> Maybe there could be an option to support such behavior (but the
> code will look very ugly).
>
> I've ran into this problem when tried to use OpenWRT appliance in
> cloud environment.  Can't use other DHCP clients, because use of
> udhcpc is hardcoded.  If you thing that size increase does not
> worth it, I'll submit this patch in OpenWRT for x86/kvm_guest
> target...

Ok, let's apply it...


More information about the busybox mailing list