problem with start-stop-daemon and --exec

[Denys Vlasenko]

On Mon, Mar 5, 2012 at 7:00 PM, Ed W <lists at wildgooses.com> wrote:
>> And /proc/pid/exe match will also work.
>> IOW: the fix I committed should be enough. No?
>
> I believe your fix would work for the nginx case, but I think it won't be
> sufficient to match a busybox executable (or similar hardlinked type
> application) which changes it's cmdline?

Yes, that app would not be stopped. But bbox doesn't change its cmdline :)

> On the other hand simply looking for the --exec string to match anywhere in
> the /proc/pid/cmdline appears to solve both cases, ie use strstr rather than
> strcmp?

strstr is too permissive. Think how many processes --exec n (for example)
will match.

> As long as I can kill all my processes I don't think I care - just seemed
> that swapping to a strstr, ie substring match seems simpler?
>
> Is the verdict to stick with /proc/pid/exe though?

This matches what manpages say.
-- 
vda