unzip applet not working ?
Denys Vlasenko
vda.linux at googlemail.com
Tue Jun 26 14:18:18 UTC 2012
On Sat, Jun 23, 2012 at 9:52 PM, Doug Clapp <doug.clapp at triad.rr.com> wrote:
>> commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
>> Author: Denys Vlasenko <vda.linux at googlemail.com>
>> Date: Fri Jun 15 16:43:26 2012 +0200
>>
>> unzip: make options parsing more robust on getopt w/o gnu extensions
>>
>> Also, code shrank:
>>
>> function old new
>> delta
>> static.extn 15 10
>> -5
>> packed_usage 29231 29217
>> -14
>> unzip_main 2388 2291
>> -97
>>
>> ------------------------------------------------------------------------------
>> (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-116)
>> Total: -116 bytes
>>
>>
>> After it, only -x will break.
>> _______________________________________________
>> busybox mailing list
>> busybox at busybox.net
>> http://lists.busybox.net/mailman/listinfo/busybox
>>
> Attached is new source file unzip.c. Following John Spencer's email on June
> 14, I decided to tackle his suggestion of parsing the command line without
> getopt. I think I have succeeded in that. One minor issue is -qq, which is
> treated the same as -q. If you want the -qq behavior, use -q -q. If I did it
> right, the output from make bloatcheck is:
>
> function old new delta
> unzip_main 1564 1925 +361
> .rodata 2389 2384 -5
> ------------------------------------------------------------------------------
> (add/remove: 0/0 grow/shrink: 1/1 up/down: 361/-5) Total: 356
> bytes
> text data bss dec hex filename
> 24894 430 44 25368 6318 busybox_old
> 25274 434 44 25752 6498 busybox_unstripped
>
> In my testing both -d and -x appear to function correctly.
>
> I have made documentation suggestions before, but this is my first code
> contribution.
Please send a diff.
Please follow code style of the surrounding code.
Please use tabs consistently.
--
vda
More information about the busybox
mailing list