[PATCH] Fix the "NTPv7" bug

Paul Marks paul at pmarks.net
Fri Dec 7 04:34:24 UTC 2012


On Sun, Nov 25, 2012 at 7:22 PM, Paul Marks <paul at pmarks.net> wrote:
> When using busybox ntpd with an NTPv3 client and NTPv4 server (or vice
> versa), the version numbers can be ORed together, yielding the bogus
> value 7.
>
> This 1-line patch ensures that only the Leap Indicator bits are copied
> from the server status.
>
> I've done before/after tests with Chrony and Windows 7's "Internet
> Time" feature, and this patch fixed both cases.
>
> Related bug:
> https://bugs.busybox.net/show_bug.cgi?id=5120

Have I submitted this patch correctly?  I think it's fairly important.
 The ntpd server is unusable in many common scenarios without it.


More information about the busybox mailing list