[BUG] patch fails for porper path resolution

[John Spencer]

On 04/17/2012 04:13 PM, Denys Vlasenko wrote:
> On Sat, Apr 14, 2012 at 4:36 AM, John Spencer
> <maillist-busybox at barfooze.de>  wrote:
>> Hello, this patch is still not applied to trunk (just checked git)
>>
>> Denys, could you please apply this finally?
> It is fixed in git Mon Oct 10 19:59:38 2011.
> See commit 39ec6a2ad5dae93c125b766eb8e705742216797a
>
that's very interesting. the commit

39ec6a2ad5dae93c125b766eb8e705742216797a

looks quite different to robs original patch.

the weird thing tho is that rob's original patch applies cleanly to 1.19.4, which led me to my reinvestigation.

btw:
+				for (i = 0, s = name; *s;) {
it took quite a while to figure that this isn't:
  for (i = 0; s = name; *s;)
writing this as i = 0; s = name; while(*s) would make the intent clear on the first glance.

--JS