[PATCHv3] httpd: don't drop/abuse QUERY_STRING when /cgi-bin/index.cgi is used

Peter Korsgaard jacmet at sunsite.dk
Mon Dec 19 11:54:57 UTC 2011


>>>>> "Denys" == Denys Vlasenko <vda.linux at googlemail.com> writes:

Hi,

 >> The memory pointed to by g_query gets overwritten when the index_page
 >> is used, causing URL arguments to get dropped when we fall back to
 >> /cgi-bin/index.cgi. QUERY_STRING if furthermore hijacked to pass the
 >> original (<DIR>/) URI to the CGI script, which is quite non-standard
 >> and disallows use of URL arguments.
 >> 
 >> Fix it by instead passing the original URI in REQUEST_URI, and make a
 >> deep copy of the URL arguments before they get overwritten, if needed.
 >> 
 >> Also update httpd_indexcgi to take the directory location from
 >> REQUEST_URI instead.

 Denys> Applied, thanks!

Thanks. Any reason why you dropped most of my commit message? Don't you
use 'git am -s' to apply it?

-- 
Bye, Peter Korsgaard


More information about the busybox mailing list