[PATCH] gen_build_files.sh: rewrite with sed

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Nov 18 18:25:08 UTC 2010


On Wed, Nov 17, 2010 at 11:58:21PM +0100, Cristian Ionescu-Idbohrn wrote:
>On Tue, 16 Nov 2010, Bernhard Reutner-Fischer wrote:
>> On Tue, Nov 16, 2010 at 09:31:13PM +0100, Cristian Ionescu-Idbohrn wrote:
>> >On Tue, 16 Nov 2010, Mike Frysinger wrote:
>> >>
>> >> The shell parsing of files is incredibly slow on many systems.  With
>> >> one report, the process was taking a minute or two which made people
>> >> thing the build was hung.  So rewrite the craziness with sed and proper
>> >> shell functions.  On an idle system, this cut the runtime by half.
>> >
>> >Sounds good.  Still, you can surely explain the inconsistant and totally
>> >superfluous curly brackets around variable names.
>>
>> The whole shell thing is superfluous.
>
>Right.  You've convinced me about that :)  Still...
>
>> I've rewritten that stuff in make (where it belongs or at least fits
>> better) here, FYA:
>
>I'm not that amused.
>
>I may be missing something but, AFAICS, this:
>
>> http://news.gmane.org/gmane.linux.busybox/cutoff=30983
>
>is about "The size comparison of the ifplugd daemon in busybox".  Where's
>the relevance?

http://article.gmane.org/gmane.linux.busybox/30917

I'm not pursuing this anymore so if someone wants to discuss this with
Denys please feel free to do so.


More information about the busybox mailing list