[PATCH] gen_build_files.sh: rewrite with sed

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Wed Nov 17 22:58:21 UTC 2010


On Tue, 16 Nov 2010, Bernhard Reutner-Fischer wrote:
> On Tue, Nov 16, 2010 at 09:31:13PM +0100, Cristian Ionescu-Idbohrn wrote:
> >On Tue, 16 Nov 2010, Mike Frysinger wrote:
> >>
> >> The shell parsing of files is incredibly slow on many systems.  With
> >> one report, the process was taking a minute or two which made people
> >> thing the build was hung.  So rewrite the craziness with sed and proper
> >> shell functions.  On an idle system, this cut the runtime by half.
> >
> >Sounds good.  Still, you can surely explain the inconsistant and totally
> >superfluous curly brackets around variable names.
>
> The whole shell thing is superfluous.

Right.  You've convinced me about that :)  Still...

> I've rewritten that stuff in make (where it belongs or at least fits
> better) here, FYA:

I'm not that amused.

I may be missing something but, AFAICS, this:

> http://news.gmane.org/gmane.linux.busybox/cutoff=30983

is about "The size comparison of the ifplugd daemon in busybox".  Where's
the relevance?


Cheers,

-- 
Cristian


More information about the busybox mailing list