[PATCH] gen_build_files.sh: rewrite with sed

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Tue Nov 16 21:06:05 UTC 2010


On Tue, Nov 16, 2010 at 09:31:13PM +0100, Cristian Ionescu-Idbohrn wrote:
>On Tue, 16 Nov 2010, Mike Frysinger wrote:
>>
>> The shell parsing of files is incredibly slow on many systems.  With
>> one report, the process was taking a minute or two which made people
>> thing the build was hung.  So rewrite the craziness with sed and proper
>> shell functions.  On an idle system, this cut the runtime by half.
>
>Sounds good.  Still, you can surely explain the inconsistant and totally
>superfluous curly brackets around variable names.

The whole shell thing is superfluous.
I've rewritten that stuff in make (where it belongs or at least fits
better) here, FYA:
http://news.gmane.org/gmane.linux.busybox/cutoff=30983


More information about the busybox mailing list